Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh] Ensure zh fallback pages specify en page as canonical source #4494

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented May 15, 2024

Test pages

Look at the page source to ensure that the canonical link is appropriately set:

Before

$ curl -s https://opentelemetry.io/zh/docs/getting-started/ | perl -nle 'print $1 if /(canonical"?\s+href=.*?)>/i'
canonical href=https://opentelemetry.io/zh/docs/getting-started/

After

$ curl -s https://deploy-preview-4494--opentelemetry.netlify.app/zh/docs/getting-started/ | perl -nle 'print $1 if /(canonical"?\s+href=.*?)>/i'
canonical href=https://deploy-preview-4494--opentelemetry.netlify.app/docs/getting-started/

@chalin chalin force-pushed the chalin-im-zh-add-canonical-url-2024-05-15 branch from 475009f to 912da5d Compare May 16, 2024 07:59
@chalin chalin merged commit bc8a24b into open-telemetry:main May 16, 2024
15 checks passed
@chalin chalin deleted the chalin-im-zh-add-canonical-url-2024-05-15 branch May 16, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants