-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zh] Add new pages: what-is-opentelemetry and its _index.md #4481
Conversation
content/zh/_index.md
Outdated
- [了解更多](/docs/what-is-opentelemetry/) | ||
- [了解更多](/zh/docs/what-is-opentelemetry/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chalin is there a way to express "go to the language specific docs and if you do not find them go to the english ones"? We will need this more often in the future and eventually it will be hard to track which links are pointing where
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the first few doc pages @windsonsea.
@svrnm - I still need to experiment with Hugo so see what the best way forward is. We might have a few alternatives with tradeoffs to consider. I'll report back here as soon as I can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@svrnm - with the config I've setup, the proper thing to do in the zh
pages is to lead all URLs with /zh/
unless there is a wish to intentionally target an en
page. Does that make sense to you all?
The fallback is implemented via Hugo mounts.
All, this is what the Docs section will look like with an English-page fallback (also see the preview): ... If you like this, then I propose that we move forward with this approach. I still need to fix the broken links. I'll do that soon, but wanted to get the previous out to you first. I also need to fix canonical link URLs, but I don't want to hold this PR back because of it. |
1559542
to
3a9f4d4
Compare
All checks are passing, and I've implemented all changes I wanted to put in place. This is good to go, and ready for a final approval @svrnm et al. |
Signed-off-by: windsonsea <[email protected]>
Signed-off-by: windsonsea <[email protected]>
Preview https://deploy-preview-4481--opentelemetry.netlify.app/zh/docs/