Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh] Add new pages: what-is-opentelemetry and its _index.md #4481

Merged
merged 6 commits into from
May 15, 2024

Conversation

windsonsea
Copy link
Member

@windsonsea windsonsea commented May 14, 2024

@windsonsea windsonsea requested a review from a team May 14, 2024 07:10
@svrnm svrnm added the lang:zh label May 14, 2024
- [了解更多](/docs/what-is-opentelemetry/)
- [了解更多](/zh/docs/what-is-opentelemetry/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalin is there a way to express "go to the language specific docs and if you do not find them go to the english ones"? We will need this more often in the future and eventually it will be hard to track which links are pointing where

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the first few doc pages @windsonsea.

@svrnm - I still need to experiment with Hugo so see what the best way forward is. We might have a few alternatives with tradeoffs to consider. I'll report back here as soon as I can.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svrnm - with the config I've setup, the proper thing to do in the zh pages is to lead all URLs with /zh/ unless there is a wish to intentionally target an en page. Does that make sense to you all?

The fallback is implemented via Hugo mounts.

content/zh/what-is-opentelemetry.md Outdated Show resolved Hide resolved
@windsonsea windsonsea changed the title [zh] Add a new page: what-is-opentelemetry.md [zh] Add a new page: what-is-opentelemetry and its _index.md May 14, 2024
@windsonsea windsonsea changed the title [zh] Add a new page: what-is-opentelemetry and its _index.md [zh] Add new pages: what-is-opentelemetry and its _index.md May 14, 2024
@chalin chalin self-assigned this May 14, 2024
content/zh/docs/_index.md Outdated Show resolved Hide resolved
content/zh/docs/_index.md Outdated Show resolved Hide resolved
content/zh/docs/what-is-opentelemetry.md Outdated Show resolved Hide resolved
@chalin
Copy link
Contributor

chalin commented May 14, 2024

All, this is what the Docs section will look like with an English-page fallback (also see the preview):

image ...

If you like this, then I propose that we move forward with this approach. I still need to fix the broken links. I'll do that soon, but wanted to get the previous out to you first.

I also need to fix canonical link URLs, but I don't want to hold this PR back because of it.

@chalin chalin requested a review from svrnm May 14, 2024 11:12
@chalin chalin force-pushed the whatis branch 3 times, most recently from 1559542 to 3a9f4d4 Compare May 14, 2024 17:11
@chalin
Copy link
Contributor

chalin commented May 14, 2024

All checks are passing, and I've implemented all changes I wanted to put in place. This is good to go, and ready for a final approval @svrnm et al.

@svrnm svrnm merged commit 6e35a94 into open-telemetry:main May 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[zh] Add a first docs page
3 participants