-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the OpenTelemetry Collector based on OpenLLMetry to Registry #4451
Conversation
cc @gyliu513 |
@theletterf @gyliu513 Could you please merge the PR, I am not authorized. Thanks. |
We need more approvals before going forward. |
@@ -0,0 +1,19 @@ | |||
# cSpell:ignore openllmetry Instana | |||
title: IBM OpenTelemetry Collector for LLM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repository title is "OTel based Data Collector for LLM", what is the difference here?
Also "IBM OpenTelemetry Collector for LLM" goes against the trademark requirements for OpenTelemetry, see https://www.linuxfoundation.org/legal/trademark-usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title has been changed to be same as in repository.
- java | ||
- receiver | ||
- collector | ||
license: Apache 2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repository is MIT licensed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's MIT. Thanks.
repo: https://github.com/instana/otel-dc/tree/main/llm | ||
createdAt: 2024-05-07 | ||
package: | ||
registry: packagist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for PHP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed. Thanks.
- receiver | ||
- collector | ||
license: Apache 2.0 | ||
description: IBM OpenTelemetry Collector for LLM based on Instrumentations of OpenLLMetry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the description in the repository more, this is just a long version of the title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description has been changed to be same as in the repository. Thanks.
@svrnm Thank you for your detailed advise! Could you please review again. |
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9058775976 |
No description provided.