Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the OpenTelemetry Collector based on OpenLLMetry to Registry #4451

Merged
merged 5 commits into from
May 13, 2024

Conversation

jinsongo
Copy link
Contributor

@jinsongo jinsongo commented May 8, 2024

No description provided.

@jinsongo jinsongo requested a review from a team May 8, 2024 17:19
@jinsongo jinsongo changed the title Add OpenTelemetry Collector over OpenLLMetry to Registry Add the OpenTelemetry Collector based on OpenLLMetry to Registry May 8, 2024
@jinsongo
Copy link
Contributor Author

jinsongo commented May 8, 2024

cc @gyliu513

@jinsongo
Copy link
Contributor Author

@theletterf @gyliu513 Could you please merge the PR, I am not authorized. Thanks.

@theletterf
Copy link
Member

We need more approvals before going forward.

@@ -0,0 +1,19 @@
# cSpell:ignore openllmetry Instana
title: IBM OpenTelemetry Collector for LLM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repository title is "OTel based Data Collector for LLM", what is the difference here?

Also "IBM OpenTelemetry Collector for LLM" goes against the trademark requirements for OpenTelemetry, see https://www.linuxfoundation.org/legal/trademark-usage

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title has been changed to be same as in repository.

- java
- receiver
- collector
license: Apache 2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repository is MIT licensed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's MIT. Thanks.

repo: https://github.com/instana/otel-dc/tree/main/llm
createdAt: 2024-05-07
package:
registry: packagist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for PHP

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. Thanks.

- receiver
- collector
license: Apache 2.0
description: IBM OpenTelemetry Collector for LLM based on Instrumentations of OpenLLMetry.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the description in the repository more, this is just a long version of the title

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description has been changed to be same as in the repository. Thanks.

@jinsongo
Copy link
Contributor Author

@svrnm Thank you for your detailed advise! Could you please review again.

@svrnm
Copy link
Member

svrnm commented May 13, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

@svrnm svrnm merged commit 58dc919 into open-telemetry:main May 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants