Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove APAC end-user discussion group #4450

Merged

Conversation

danielgblanco
Copy link
Contributor

@danielgblanco danielgblanco commented May 8, 2024

As of open-telemetry/sig-end-user#7 we no longer think running an end-user discussion group in APAC is productive.

This PR removes the end-user content related to monthly discussion groups, which have been discontinued as part of wider open-telemetry/community#2052

cc @open-telemetry/sig-end-user-approvers

@danielgblanco danielgblanco requested review from a team May 8, 2024 15:08
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. See inline comments.

content/en/community/end-user/discussion-group.md Outdated Show resolved Hide resolved
content/en/community/end-user/discussion-group.md Outdated Show resolved Hide resolved
@chalin
Copy link
Contributor

chalin commented May 9, 2024

Btw, we'll fix the GH action failures after the other edits are done.

@danielgblanco
Copy link
Contributor Author

Thanks, I'm travelling at the moment but will have a look at the failed checks ASAP.

@danielgblanco danielgblanco requested review from a team May 13, 2024 14:32
@danielgblanco danielgblanco force-pushed the remove_apac_enduser_discussions branch from 568611c to 28b0b57 Compare May 13, 2024 14:38
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you address the last suggestion, this LGTM.

@chalin chalin force-pushed the remove_apac_enduser_discussions branch from 9666f43 to 1227c2e Compare May 13, 2024 23:40
@chalin
Copy link
Contributor

chalin commented May 14, 2024

@danielgblanco - I'm curious why you added @open-telemetry/specs-approvers to the reviewers list?

Ping @open-telemetry/sig-end-user-approvers.

@danielgblanco
Copy link
Contributor Author

@chalin

I'm curious why you added @open-telemetry/specs-approvers to the reviewers list?

I think that was added when I accidentally pushed a change that contained changes to git submodules...

@svrnm svrnm added the sig-approval-missing Co-owning SIG didn't provide an approval label May 15, 2024
@svrnm
Copy link
Member

svrnm commented May 15, 2024

lgtm, @danielgblanco can you ask someone else from @open-telemetry/sig-end-user-approvers to approve it as well? Thanks.

@chalin chalin force-pushed the remove_apac_enduser_discussions branch from 2a914c1 to 9a468ef Compare May 15, 2024 08:57
Copy link
Contributor

@avillela avillela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chalin chalin removed the sig-approval-missing Co-owning SIG didn't provide an approval label May 16, 2024
@chalin chalin merged commit 7244f2d into open-telemetry:main May 16, 2024
15 checks passed
@chalin
Copy link
Contributor

chalin commented May 16, 2024

Thank you all ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants