-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove APAC end-user discussion group #4450
Remove APAC end-user discussion group #4450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. See inline comments.
Btw, we'll fix the GH action failures after the other edits are done. |
Thanks, I'm travelling at the moment but will have a look at the failed checks ASAP. |
568611c
to
28b0b57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you address the last suggestion, this LGTM.
9666f43
to
1227c2e
Compare
@danielgblanco - I'm curious why you added @open-telemetry/specs-approvers to the reviewers list? Ping @open-telemetry/sig-end-user-approvers. |
I think that was added when I accidentally pushed a change that contained changes to git submodules... |
lgtm, @danielgblanco can you ask someone else from @open-telemetry/sig-end-user-approvers to approve it as well? Thanks. |
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
2a914c1
to
9a468ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you all ✨ |
As of open-telemetry/sig-end-user#7 we no longer think running an end-user discussion group in APAC is productive.
This PR removes the end-user content related to monthly discussion groups, which have been discontinued as part of wider open-telemetry/community#2052
cc @open-telemetry/sig-end-user-approvers