Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blog post for OTel Collector Survey #4409

Merged
merged 18 commits into from
May 8, 2024
Merged

Add blog post for OTel Collector Survey #4409

merged 18 commits into from
May 8, 2024

Conversation

IAMebonyhope
Copy link
Contributor

@IAMebonyhope IAMebonyhope commented May 2, 2024 •
edited
Loading

@IAMebonyhope IAMebonyhope requested a review from a team May 2, 2024 06:01
@github-actions github-actions bot added the blog label May 2, 2024
theletterf
theletterf approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fascinating results! Thanks!

@theletterf
Copy link
Member

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8920726253

@IAMebonyhope IAMebonyhope force-pushed the otel-collector-blogpost branch from ebc4a09 to 264bf05 Compare May 3, 2024 12:33
@IAMebonyhope
Copy link
Contributor Author

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8939203975

@IAMebonyhope IAMebonyhope mentioned this pull request May 3, 2024
Closed
6 tasks
jpkrohling
jpkrohling approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I still see some problems with the images (inconsistent sizes, order of answers are odd in some places), but nothing that would block publishing it as it is.

@jpkrohling
Copy link
Member

@open-telemetry/collector-approvers , @open-telemetry/collector-contrib-approvers , could you also take a look?

codeboten
codeboten approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one non-blocking question

@svrnm
Copy link
Member

svrnm commented May 6, 2024

@IAMebonyhope can you mark all the conversations resolved as resolved, makes it easier for me to do another round of review. thanks!

@IAMebonyhope
Copy link
Contributor Author

@IAMebonyhope can you mark all the conversations resolved as resolved, makes it easier for me to do another round of review. thanks!

@svrnm Resolved all the comments

svrnm
svrnm approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

IAMebonyhope and others added 2 commits May 7, 2024 10:05
@IAMebonyhope @svrnm
Apply suggestions from code review
8aba3f2 
Co-authored-by: Severin Neumann <[email protected]>
@svrnm
fixes for CI
db766a5 
Signed-off-by: svrnm <[email protected]>
@IAMebonyhope IAMebonyhope requested a review from a team May 8, 2024 08:31
svrnm
svrnm reviewed May 8, 2024
View reviewed changes
static/refcache.json Outdated Show resolved Hide resolved
@svrnm
Copy link
Member

svrnm commented May 8, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8999082270

@svrnm svrnm merged commit 122d614 into open-telemetry:main May 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avillela avillela avillela left review comments

@evan-bradley evan-bradley evan-bradley left review comments

@svrnm svrnm svrnm approved these changes

@crobert-1 crobert-1 crobert-1 approved these changes

@theletterf theletterf theletterf approved these changes

@codeboten codeboten codeboten approved these changes

@jpkrohling jpkrohling jpkrohling approved these changes

Assignees
No one assigned
Labels
blog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@IAMebonyhope @theletterf @opentelemetrybot @jpkrohling @svrnm @codeboten @evan-bradley @avillela @crobert-1