Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include OpenLIT to OpenTelemetry Vendors #4378

Merged
merged 9 commits into from
May 2, 2024
Merged

Conversation

patcher9
Copy link

@patcher9 patcher9 commented Apr 29, 2024

In this PR, I have added OpenLIT as a OTEL Vendors as we provide LLM Observability to our end users. I have linked out to our Repository as the source. I have included the entry in the alphabetical order in the list.

Please let me know if you have any suggestions, Thanks!

@patcher9 patcher9 requested a review from a team April 29, 2024 06:14
data/ecosystem/vendors.yaml Outdated Show resolved Hide resolved
@patcher9 patcher9 requested a review from svrnm April 29, 2024 09:44
@svrnm
Copy link
Member

svrnm commented Apr 29, 2024

@patcher9 taking a look at what OpenLIT is, it looks to me that it should be listed with "integrations" not with "vendors"

@svrnm
Copy link
Member

svrnm commented Apr 29, 2024

@patcher9 also, are you involved in the LLM Semantic Conventions SIG already?

@patcher9
Copy link
Author

patcher9 commented Apr 29, 2024

@patcher9 taking a look at what OpenLIT is, it looks to me that it should be listed with "integrations" not with "vendors"

Yeah I was a bit confused for sure. But I figured our SDK is what I was gonna add in "Integrations", But since our UI is providing dashboards which are powered by Otel data (can be any OTEL trace that is sent), Vendors made sense for the UI front.

Its quite similar to Traceloop which is listed in vendors in this list already

@patcher9 also, are you involved in the LLM Semantic Conventions SIG already?

Not involved fully involved yet, Though we follow the semantics that were merged recently as we have been following the progress for a while now

@svrnm
Copy link
Member

svrnm commented Apr 29, 2024

@patcher9 taking a look at what OpenLIT is, it looks to me that it should be listed with "integrations" not with "vendors"

Yeah I was a bit confused for sure. But I figured our SDK is what I was gonna add in "Integrations", But since our UI is providing dashboards which are powered by Otel data (can be any OTEL trace that is sent), Vendors made sense for the UI front.

Its quite similar to Traceloop which is listed in vendors in this list already

Ah, I missed the UI part then somehow, then you're at the right place. In that case the url should point to the documentation where your backend supports OTLP ingestion.

@patcher9 also, are you involved in the LLM Semantic Conventions SIG already?

Not involved fully involved yet, Though we follow the semantics that were merged recently as we have been following the progress for a while now

👍

@patcher9
Copy link
Author

patcher9 commented Apr 29, 2024

Ah, I missed the UI part then somehow, then you're at the right place. In that case the url should point to the documentation where your backend supports OTLP ingestion.

My bad, Lemme clear it a bit on how it works
OpenLIT SDK -> Otel Collector -> Clickhouse exporter -> Clickhouse(data stored) -> OpenLIT(Pulls data from Clickhouse for Visualizations, Similar to SigNoz listed in Vednors)

And now since we only work on OTEL (Actual ingestion being via collector), Linking out to the root of the repo made more sense. Based on the flow and as I saw SigNoz and traceloop directly link out to their website, I felt Repo root might be better to use

@svrnm
Copy link
Member

svrnm commented Apr 30, 2024

Ah, I missed the UI part then somehow, then you're at the right place. In that case the url should point to the documentation where your backend supports OTLP ingestion.

My bad, Lemme clear it a bit on how it works OpenLIT SDK -> Otel Collector -> Clickhouse exporter -> Clickhouse(data stored) -> OpenLIT(Pulls data from Clickhouse for Visualizations, Similar to SigNoz listed in Vednors)

Then your solution is not supporting native OTLP. Please annotate that in your entry correctly. Note that our page currently states that the vendor list only contains vendors with native OTLP support, so we might consider splitting the list out in those with native and those without native support.

And now since we only work on OTEL (Actual ingestion being via collector), Linking out to the root of the repo made more sense. Based on the flow and as I saw SigNoz and traceloop directly link out to their website, I felt Repo root might be better to use

We need to follow up with them then, because they should also point to the right documentation.

@patcher9
Copy link
Author

patcher9 commented Apr 30, 2024

Cool, Updated the native OTLP to false. Since OpenLIT is OSS only we need a seperate Clickhouse to store OTEL data which is similar to saying Grafana storing Otel traces in Tempo tbh.

Does it work now? with repo link. It does say at the heading itself OpenTelemetry-native with insctructions on ingesting data via our otel library. It feels technically the same thing as me creating a website page and writing it opentelemetry tbh. Lemme know, Wanna get this closed soon before our Demo day. Thanks!

@svrnm
Copy link
Member

svrnm commented May 2, 2024

To make it short, our vendors page does not reflect the reality of what backends do and can do anymore. It needs some rework, but that's none of your concerns (except you are open to help with that:-)), please add the link to your docs and then I'll merge in the PR

@patcher9
Copy link
Author

patcher9 commented May 2, 2024

@svrnm Updated the link to point to our docs
and yeah happy to help with any rework on the vendors page.

@svrnm
Copy link
Member

svrnm commented May 2, 2024

/fix:refcache

@opentelemetrybot
Copy link
Collaborator

You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8922156839

@svrnm
Copy link
Member

svrnm commented May 2, 2024

@svrnm Updated the link to point to our docs and yeah happy to help with any rework on the vendors page.

Appreciated, I will raise an issue and tag you there as well (maybe we have one already so I might reuse that one, need to check)

@svrnm svrnm merged commit 1ba0c6c into open-telemetry:main May 2, 2024
5 checks passed
@patcher9 patcher9 deleted the patch-2 branch May 2, 2024 10:50
@patcher9
Copy link
Author

patcher9 commented May 2, 2024

Hey @svrnm one question

I missed to add the distribution: true. This should be true correct since the SDK does give Auto Instrumentation for various LLM and VectorDBs?

Also Can I add the SDK to the Integrations page, Seems like a good fit?

Just wanted to confirm on these two before I make another PR
Thanks!

@svrnm
Copy link
Member

svrnm commented May 3, 2024

I missed to add the distribution: true. This should be true correct since the SDK does give Auto Instrumentation for various LLM and VectorDBs?

Distributions is not used anymore, since we have a dedicated page for them: https://opentelemetry.io/ecosystem/distributions/

Also Can I add the SDK to the Integrations page, Seems like a good fit?

It's either a distribution or an integration. Spreading it out across all the pages is not something we should do as it decreases the value of each page. I think your SDK is best described as a distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants