Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include more detail in the ToC on right side #4321

Merged
merged 2 commits into from
Apr 19, 2024
Merged

include more detail in the ToC on right side #4321

merged 2 commits into from
Apr 19, 2024

Conversation

zeitlinger
Copy link
Member

Easier navigation:

image

@zeitlinger zeitlinger self-assigned this Apr 18, 2024
@zeitlinger zeitlinger requested a review from a team April 18, 2024 11:43
@svrnm svrnm added the ux label Apr 19, 2024
svrnm
svrnm approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am personally OK with this change, but I would like to get some more @open-telemetry/docs-maintainers to take a look

@theletterf
Copy link
Member

@zeitlinger Not opposed to this, but I'd consider splitting the docs to create a subsection just for Sprint Boot, given its popularity.

@svrnm
Copy link
Member

svrnm commented Apr 19, 2024

@zeitlinger Not opposed to this, but I'd consider splitting the docs to create a subsection just for Sprint Boot, given its popularity.

Yes, we should consider splitting this page, also it doesn't feel right to have "Spring Boot" under "Automatic", but let's move that into a dedicated discussion

@zeitlinger
Copy link
Member Author

Yes, we should consider splitting this page, also it doesn't feel right to have "Spring Boot" under "Automatic", but let's move that into a dedicated discussion

Thanks for the suggestion! Created #4324

@cartermp
Copy link
Contributor

'gon merge now

@cartermp cartermp merged commit cdb7877 into open-telemetry:main Apr 19, 2024
15 checks passed
@zeitlinger zeitlinger deleted the toc branch April 22, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@theletterf theletterf theletterf approved these changes

@svrnm svrnm svrnm approved these changes

@mhausenblas mhausenblas mhausenblas approved these changes

Assignees

@zeitlinger zeitlinger

Labels
ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zeitlinger @theletterf @svrnm @cartermp @mhausenblas