-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #4292 link to community guidelines at the top #4296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple nits — thanks!
You can open an issue about OpenTelemetry documentation, or contribute a change | ||
This document is related to contributing do documentation. | ||
If you are looking on how to contribute to the OpenTelemetry project in general see the | ||
[OpenTelemetry Contributor Guide](https://github.com/open-telemetry/community/blob/main/CONTRIBUTING.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we also include a wording to indicate that every language implementation, collector, conventions repo has their own specific contributing guides as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there also any place that aggregates all contributing guides?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the wording
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Reference: #4292
The page under https://opentelemetry.io/docs/contributing/ talks about contributing to docs, although people might expect a page on how to contribute to the OpenTelemetry project in general. You have to read down a little bit to run into See also the general OpenTelemetry Contributor Guide, which provides details on the Contributor License Agreement and the Code of Conduct.
I think we should have this at the very top that this document is for contributing to docs and that the other document is where people find general guidelines.