Fix default collector deployment receiver endpoint #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwildman
requested review from
a team and
bogdandrutu
and removed request for
a team
|
@open-telemetry/collector-approvers WDYT? |
theletterf
approved these changes
Apr 12, 2024
mx-psi
approved these changes
Apr 12, 2024
codeboten
approved these changes
Apr 12, 2024
In the default deployment example the export configuration is expecting to use OTLP over HTTP on port 4318. The collector examples though is then showing configuration for receivers on gRPC over 4317, instead of 4318.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the default deployment example the export configuration is expecting to use OTLP over HTTP on port 4318.
The collector examples though is then showing configuration for receivers on gRPC over 4317, instead of 4318.
I assume this was just an oversight when HTTP became the default.