Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenTelemetry-Matlab to registry #4284

Merged
merged 7 commits into from
May 16, 2024

Conversation

duncanpo
Copy link
Contributor

Add OpenTelemetry-Matlab to registry. This is an unofficial implementation of OpenTelemetry in the MATLAB language.

@duncanpo duncanpo requested a review from a team April 11, 2024 14:45
Copy link

linux-foundation-easycla bot commented Apr 11, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@svrnm
Copy link
Member

svrnm commented Apr 11, 2024

I stumbled upon this plugin a while ago and I love the idea to have opentelmetry in Matlab, great work @duncanpo! Are you able to sign the CLA such that we can merge your PR?

@duncanpo
Copy link
Contributor Author

I stumbled upon this plugin a while ago and I love the idea to have opentelmetry in Matlab, great work @duncanpo! Are you able to sign the CLA such that we can merge your PR?

I am currently having the CLA reviewed by our legal team. When we have clearance, we should be able to sign it.

@svrnm
Copy link
Member

svrnm commented Apr 11, 2024

I stumbled upon this plugin a while ago and I love the idea to have opentelmetry in Matlab, great work @duncanpo! Are you able to sign the CLA such that we can merge your PR?

I am currently having the CLA reviewed by our legal team. When we have clearance, we should be able to sign it.

Good to hear, thanks. if you or they have any questions, follow up here and we can help to redirect them to the right people

@svrnm svrnm added the CLA: no label Apr 15, 2024
@svrnm
Copy link
Member

svrnm commented May 2, 2024

any updates @duncanpo ?

@duncanpo
Copy link
Contributor Author

duncanpo commented May 2, 2024

@svrnm, I think we are very close to ready to sign the CLA. I hope I will have more updates this week or next.

@@ -1,6 +1,6 @@
title: OpenTelemetry-Matlab
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: OpenTelemetry-Matlab
# cSpell:ignore matlab simulink
title: OpenTelemetry-Matlab

@cartermp
Copy link
Contributor

/fix:refcache

@opentelemetrybot
Copy link
Collaborator

You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9086477124

@opentelemetrybot
Copy link
Collaborator

fix:refcache run failed, please check https://github.com/open-telemetry/opentelemetry.io/actions/runs/9086477124 for details

@cartermp
Copy link
Contributor

@duncanpo to fix the CI error, you'll need to run npm run fix on your branch

@duncanpo
Copy link
Contributor Author

@duncanpo to fix the CI error, you'll need to run npm run fix on your branch

This is fixed now.

@svrnm svrnm merged commit 25f69c0 into open-telemetry:main May 16, 2024
15 checks passed
@svrnm
Copy link
Member

svrnm commented May 16, 2024

Thanks @duncanpo! See https://opentelemetry.io/ecosystem/integrations/ -- it's live already!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants