Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note about default protocol of spring boot starter #4258

Merged
merged 10 commits into from
Apr 15, 2024

Conversation

@zeitlinger zeitlinger self-assigned this Apr 5, 2024
@zeitlinger zeitlinger requested review from a team April 5, 2024 15:15
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the source where the defaults are listed instead, to mention this for both the Java agent and Spring boot starter?

@chalin
Copy link
Contributor

chalin commented Apr 6, 2024

/fix:all

Copy link
Contributor

github-actions bot commented Apr 6, 2024

@chalin chalin force-pushed the spring-boot-default-protocol branch from 8cc03a1 to 4801292 Compare April 6, 2024 09:39
@svrnm svrnm added the sig:java label Apr 8, 2024
@svrnm
Copy link
Member

svrnm commented Apr 8, 2024

@open-telemetry/java-approvers PTAL

@zeitlinger zeitlinger force-pushed the spring-boot-default-protocol branch from 24d5609 to 0fa437c Compare April 11, 2024 11:47
@zeitlinger
Copy link
Member Author

/fix:format

Copy link
Contributor

@svrnm svrnm merged commit b9b918c into open-telemetry:main Apr 15, 2024
14 checks passed
@zeitlinger zeitlinger deleted the spring-boot-default-protocol branch April 15, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spring Boot: Error when configuring OTLP exporter in application.properties
7 participants