Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semantic-conventions version to v1.25.0 #4253

Merged

Conversation

opentelemetrybot
Copy link
Collaborator

@opentelemetrybot opentelemetrybot requested review from a team April 4, 2024 17:15
@chalin chalin self-assigned this Apr 4, 2024
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an invalid URL hash reported by the link checker which is preventing me from accepting this PR as is:

docs/specs/semconv/attributes-registry/service/index.html
  ...
  hash does not exist --- docs/specs/semconv/attributes-registry/service/index.html --> /docs/specs/semconv/attributes-registry/process/#process

I'll tweak the adjust-pages script as soon as I'm more fully back only (storm knocked out power and internet).

chalin added a commit to chalin/semantic-conventions that referenced this pull request Apr 4, 2024
This PR normalizes the link to process.md, droping the hash to the page title, since that breaks link checking in the OTel website, see open-telemetry/opentelemetry.io#4253 (review).
@chalin
Copy link
Contributor

chalin commented Apr 5, 2024

/fix:refcache

Copy link
Contributor

github-actions bot commented Apr 5, 2024

You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8562856478

Copy link
Contributor

github-actions bot commented Apr 5, 2024

fix:refcache run failed, please check https://github.com/open-telemetry/opentelemetry.io/actions/runs/8562856478 for details

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green now that the adjust script has been (temporarily) patched, and the refcache updated.

@chalin chalin merged commit 426fa3b into main Apr 5, 2024
16 checks passed
@chalin chalin deleted the opentelemetrybot/auto-update-semantic-conventions-v1.25.0 branch April 5, 2024 00:23
@chalin chalin restored the opentelemetrybot/auto-update-semantic-conventions-v1.25.0 branch April 6, 2024 14:59
@svrnm svrnm deleted the opentelemetrybot/auto-update-semantic-conventions-v1.25.0 branch December 9, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants