Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update span events/attributes guidance based on missed feedback #4190

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

cartermp
Copy link
Contributor

I missed feedback here: #4185

@cartermp cartermp requested a review from a team March 21, 2024 10:17
@cartermp
Copy link
Contributor Author

@theletterf I made tiiiny tweaks based on your suggestions but these should largely be the same.

Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks mate!

@cartermp
Copy link
Contributor Author

/fix:format

Copy link
Contributor

@cartermp cartermp merged commit 926a8d9 into main Mar 21, 2024
16 checks passed
@cartermp cartermp deleted the cartermp-patch-2 branch March 21, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants