Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: Enhancing Acknowledgment of Community Contributions in OpenTelemetry Profiling #4186

Merged
merged 17 commits into from
Mar 21, 2024

Conversation

Rperry2174
Copy link
Contributor

@Rperry2174 Rperry2174 commented Mar 20, 2024

This PR introduces modifications to the blog post about OpenTelemetry's profiling support to better acknowledge the contributions of various community members and organizations. The key changes include:

Expanded Acknowledgements: We're enhancing the acknowledgements section to highlight the collaborative efforts within the Profiling SIG.

Inclusive Recognition: Specifically mentioning contributions from companies like Grafana Labs, Datadog, and Red Hat to recognize their significant input

Highlighting Community Contributions:

  • Mentioning the proposals for the profiling data model (OTEPs 237 and 239)
  • Acknowledging the broad-based discussion and alignment within the community on the profiling data format.

These changes aim to reflect the collective and diverse efforts that have been instrumental in advancing OpenTelemetry's profiling capabilities, ensuring that more key contributors are recognized and it's clearer that this is a community effort

More discussion on this in the thread here
relevant prs: #4183

@Rperry2174 Rperry2174 requested a review from a team March 20, 2024 10:38
@Rperry2174 Rperry2174 requested a review from a team March 20, 2024 10:52
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a good addition.

@cartermp
Copy link
Contributor

/fix:all

Copy link
Contributor

Copy link
Member

@austinlparker austinlparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temp hold on this

@cartermp
Copy link
Contributor

yee yee

@disfluxly
Copy link

This is definitely needed. As a community member that has followed this pretty closely, I was very surprised not seeing Ryan and/or Grafana Labs anywhere in the original post.

@tedsuo
Copy link
Contributor

tedsuo commented Mar 20, 2024

Sorry to fuss over a blog post, but is it possible to list the people, not the companies? In OTel we prefer to highlight individual contributions, it sometimes ruffle feathers when public communication from the project can be interpreted as an advertisement for certain companies.

If it's a big donation it's one thing, but when we're talking about SIG contributions we try to focus on individuals.

Copy link
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ryan 🙇

@felixge
Copy link
Member

felixge commented Mar 20, 2024

Sorry to fuss over a blog post, but is it possible to list the people, not the companies? In OTel we prefer to highlight individual contributions, it sometimes ruffle feathers when public communication from the project can be interpreted as an advertisement for certain companies.

If it's a big donation it's one thing, but when we're talking about SIG contributions we try to focus on individuals.

How about naming individuals with their company names in parens? Otherwise this approach raises questions about the value of SIG work vs code donations.

@cartermp
Copy link
Contributor

How about naming individuals with their company names in parens?

I would support this. Most of us work as a mix of individual contributions and time spent on behalf of our companies. It's just a nice big smorgasborg of attribution

Copy link
Member

@austinlparker austinlparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@austinlparker austinlparker merged commit 2904ea5 into open-telemetry:main Mar 21, 2024
11 of 12 checks passed
@tedsuo
Copy link
Contributor

tedsuo commented Mar 21, 2024

@felixge thats totally fine, it's usually how we do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants