-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog: Enhancing Acknowledgment of Community Contributions in OpenTelemetry Profiling #4186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is a good addition.
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8358851617 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
temp hold on this
yee yee |
This is definitely needed. As a community member that has followed this pretty closely, I was very surprised not seeing Ryan and/or Grafana Labs anywhere in the original post. |
Sorry to fuss over a blog post, but is it possible to list the people, not the companies? In OTel we prefer to highlight individual contributions, it sometimes ruffle feathers when public communication from the project can be interpreted as an advertisement for certain companies. If it's a big donation it's one thing, but when we're talking about SIG contributions we try to focus on individuals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ryan 🙇
content/en/blog/2024/opentelemetry-announced-support-for-profiling.md
Outdated
Show resolved
Hide resolved
How about naming individuals with their company names in parens? Otherwise this approach raises questions about the value of SIG work vs code donations. |
I would support this. Most of us work as a mix of individual contributions and time spent on behalf of our companies. It's just a nice big smorgasborg of attribution |
…ling.md Co-authored-by: Felix Geisendörfer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@felixge thats totally fine, it's usually how we do it. |
This PR introduces modifications to the blog post about OpenTelemetry's profiling support to better acknowledge the contributions of various community members and organizations. The key changes include:
Expanded Acknowledgements: We're enhancing the acknowledgements section to highlight the collaborative efforts within the Profiling SIG.
Inclusive Recognition: Specifically mentioning contributions from companies like Grafana Labs, Datadog, and Red Hat to recognize their significant input
Highlighting Community Contributions:
These changes aim to reflect the collective and diverse efforts that have been instrumental in advancing OpenTelemetry's profiling capabilities, ensuring that more key contributors are recognized and it's clearer that this is a community effort
More discussion on this in the thread here
relevant prs: #4183