-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: erlang elixir samples #4177
fix: erlang elixir samples #4177
Conversation
d7a2d1c
to
ad06b87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summoning @open-telemetry/erlang-approvers
@theletterf thanks! @Graborg can you explain what was wrong/fixed? |
Hi! Sure! Before the function only took into account the that the keys matched: i.e if |
ad06b87
to
41d2f32
Compare
Oooh, hah! Thanks :) Might be simpler code to just convert to a list and do a |
Sure! Something like this maybe? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 👍
Before:
should_sample
only takes into account if the keys matchedconfig
%{"http.target": "/healthcheck"}
and a span%{"http.target": "/something_else"}
would match and the span would be dropped.After:
should_sample
compares both keys and values%{"http.target": "/healthcheck"}
and a span%{"http.target": "/something_else"}
=> {:record_and_sample, [], []}%{"http.target": "/healthcheck"}
and a span%{"http.target": "/healthcheck"}
=> {:drop, [], []}