doc(k8s-operator): document customizing enabled auto-instrumentations for nodejs with kubernetes-operator #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atsu85 any updates, can you take a look at my feedback? feel free to ask questions if you are unsure how to proceed |
atsu85
force-pushed
the
4130-doc-k8s-operator-nodejs-customizing-enabled-auto-instrumentations
branch
3 times, most recently
from
beab727 to
31aa091
Compare
@svrnm, sorry for noticing this so late and thanks for the feedback. Please take a look, I hope my solution is OK. |
svrnm
reviewed
Apr 11, 2024
pavolloffay
approved these changes
Apr 11, 2024
atsu85
force-pushed
the
4130-doc-k8s-operator-nodejs-customizing-enabled-auto-instrumentations
branch
from
31aa091 to
30c355a
Compare
atsu85
force-pushed
the
4130-doc-k8s-operator-nodejs-customizing-enabled-auto-instrumentations
branch
from
30c355a to
92478ad
Compare
|
FYI: amended commits to fix linting errors (only includes changes done by |
jaronoff97
approved these changes
Apr 11, 2024
… for nodejs with kubernetes-operator Closes 4130
atsu85
force-pushed
the
4130-doc-k8s-operator-nodejs-customizing-enabled-auto-instrumentations
branch
from
ad12e34 to
87a3835
Compare
|
@svrnm , please approve this PR again! I saw that Spelling check action was failing, because of |
svrnm
approved these changes
Apr 12, 2024
|
Thank you @atsu85 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change
Current documentation states that it isn't possible to disable specific nodejs auto-instrumentation packages when using kubernetes-operator, but that isn't true after next kubernetes operator release, that allows enabling instrumentations based on
OTEL_NODE_ENABLED_INSTRUMENTATIONSenvironment variable.[UPDATE:] Dependancy PRs released for now
This documentation change is caused by feature enabled by merged PR
that currently isn't released (hence the DRAFT status of this PR),
and another PR that built the foundation for it.