Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[demo] Replace references to feature flag service with flagd #4058

Merged
merged 20 commits into from
Mar 11, 2024

Conversation

austinlparker
Copy link
Member

docs updates for v1.9, ff service deprecation in favor of flagd.

@austinlparker
Copy link
Member Author

This is waiting for open-telemetry/opentelemetry-demo#1388 to merge before it can be reviewed

@svrnm svrnm added the sig:demo label Mar 5, 2024
@austinlparker austinlparker marked this pull request as ready for review March 7, 2024 15:17
@austinlparker austinlparker requested review from a team March 7, 2024 15:17
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor comment.

content/en/docs/demo/requirements/architecture.md Outdated Show resolved Hide resolved
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a few minor things.

If you want to, you can add flagd to the cspell.yml and add OpenFeature to textlintrc to make sure it is written in that form

content/en/docs/demo/feature-flags.md Outdated Show resolved Hide resolved
content/en/docs/demo/requirements/architecture.md Outdated Show resolved Hide resolved
@svrnm
Copy link
Member

svrnm commented Mar 11, 2024

/fix:all

Copy link
Contributor

Copy link
Contributor

fix:all run failed, please check https://github.com/open-telemetry/opentelemetry.io/actions/runs/8234836163 for details

@svrnm
Copy link
Member

svrnm commented Mar 11, 2024

I forgot an https in my suggestion, fixed that.

@austinlparker I have a list of PRs I am going to merge right now, I will handle this one as well.

@svrnm
Copy link
Member

svrnm commented Mar 11, 2024

/fix:all

Copy link
Contributor

@svrnm svrnm merged commit 5c81d39 into open-telemetry:main Mar 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants