-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[demo] Replace references to feature flag service with flagd #4058
Conversation
This is waiting for open-telemetry/opentelemetry-demo#1388 to merge before it can be reviewed |
Co-authored-by: Michael Beemer <[email protected]>
Co-authored-by: Michael Beemer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only a few minor things.
If you want to, you can add flagd to the cspell.yml and add OpenFeature to textlintrc to make sure it is written in that form
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8234836163 |
fix:all run failed, please check https://github.com/open-telemetry/opentelemetry.io/actions/runs/8234836163 for details |
I forgot an https in my suggestion, fixed that. @austinlparker I have a list of PRs I am going to merge right now, I will handle this one as well. |
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8235024578 |
docs updates for v1.9, ff service deprecation in favor of flagd.