Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix submodule sync & pr-action adjustments #4021

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 17, 2024

  • NPM script changes:
    • Creates fix:all, as the canonical name for fix, which is kept as an alias
    • Creates fix:submodules, which first gets all submodules and then syncs them (previously, just syncing without first updating the submodules could fail)
    • Creates fix:refcache to match PR-action command name
    • Renames sync to _sync, since most users will not use the more robust fix:submodules
  • Adjusted the pr-action workflow to invoke npm run fix:<cmd> for the various commands. Refactored the case statement to make it more DRY
  • Minor prose tweaks and script-name adjustments to Contributing page

@chalin chalin added the CI/infra CI & infrastructure label Feb 17, 2024
@chalin chalin requested review from a team February 17, 2024 21:50
@chalin chalin mentioned this pull request Feb 17, 2024
8 tasks
@cartermp cartermp merged commit 855d651 into open-telemetry:main Feb 18, 2024
14 checks passed
@chalin chalin deleted the chalin-im-fix-sync-2024-02-17 branch February 25, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants