Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go resource example #3970

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Update Go resource example #3970

merged 3 commits into from
Feb 9, 2024

Conversation

pellared
Copy link
Member

@pellared pellared commented Feb 9, 2024

Follows open-telemetry/opentelemetry-go#4887

@open-telemetry/go-approvers PTAL

Side note: @open-telemetry/docs-approvers, actually it may be better to simply add a reference to https://pkg.go.dev/go.opentelemetry.io/otel/sdk/resource. But I would rather do it as a separate PR and also right now the example is not published on https://pkg.go.dev/go.opentelemetry.io/otel/sdk/resource.

@pellared pellared requested review from a team February 9, 2024 07:58
@cartermp cartermp merged commit 6c11c29 into main Feb 9, 2024
16 checks passed
@cartermp cartermp deleted the update-go-resource branch February 9, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants