Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dubbo in integrations. #3908

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Added Dubbo in integrations. #3908

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3ecde44
Added Dubbo in integrations.
steverao Jan 31, 2024
25a24c3
Added key word.
steverao Jan 31, 2024
6af39a2
Added comment information and can keep track of it.
steverao Feb 1, 2024
ab866e3
Results from /fix:refcache
opentelemetrybot Feb 1, 2024
f4c770e
Merge branch 'main' into steverao/main-add-integrations
svrnm Feb 1, 2024
ac3b834
Merge branch 'main' into steverao/main-add-integrations
svrnm Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion data/ecosystem/integrations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# cSpell:ignore containerd buildx Quarkus Cerbos flagd flipt KEDA Kyverno Dapr rustup GORM Otterize
# cSpell:ignore containerd buildx Quarkus Cerbos flagd flipt KEDA Kyverno Dapr rustup GORM Otterize Dubbo
- name: containerd
url: https://containerd.io/
docsUrl: https://github.com/containerd/containerd/blob/main/docs/tracing.md
Expand Down Expand Up @@ -181,3 +181,8 @@
docsUrl: https://farfetch.github.io/kafkaflow/docs/guides/open-telemetry
components: [.NET]
oss: true
- name: Dubbo # Provide the latest docs instead of blog url in 2~3 months later. refer to https://github.com/open-telemetry/opentelemetry.io/pull/3908#discussion_r1473133919.
url: https://github.com/apache/dubbo
docsUrl: https://cn.dubbo.apache.org/en/blog/2024/01/31/tracing-dubbo-with-opentelemetry/
components: [Java]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any official documentation for that? A blog post may outdate, so I rather prefer a pointer to the docs that is kept up-to-date accordingly.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I am a member of the Dubbo community.

It's been a while since we provided support for OpenTelemetry in Dubbo SDK, both apache/dubbo and apache/dubbo-go. But right now, the documentation of this part is only available in Chinese. We are in the process of building an English version of documentation for the whole site, which is expected to be publicly available in the next 2 months.

Can we accept this blog for now? I will update the official documentation when it's available ASAP.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarification, @chickenlj !

Can we do the following: Add a comment above that line pointing to this comment (https://github.com/open-telemetry/opentelemetry.io/pull/3908#discussion_r1473133919), so we can keep track of it

Beyond that I am then OK with the blog post

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can keep track of it

Thanks, I added relevant comment.

oss: true
Loading