Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporters-intro rework and mention benefits of OTLP exporters #3905

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Exporters-intro rework and mention benefits of OTLP exporters #3905

merged 5 commits into from
Feb 7, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jan 31, 2024 •
edited
Loading

Preview:

Screenshot (sample)

image

@chalin chalin requested review from a team January 31, 2024 11:40
@chalin chalin changed the title Exporters intro: rework and mention benefits of OTLP exporters Exporters-intro rework and mention benefits of OTLP exporters Jan 31, 2024
@chalin
Copy link
Contributor Author

chalin commented Jan 31, 2024

/cc @cijothomas @pegasas @theletterf @svrnm

@chalin chalin force-pushed the chalin-im-exporters-2024-01-31 branch from 5c34339 to 132c053 Compare January 31, 2024 11:47
theletterf
theletterf approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small rewording, otherwise looks good!

layouts/shortcodes/docs/languages/exporters-intro.md Outdated Show resolved Hide resolved
@chalin chalin mentioned this pull request Jan 31, 2024
Closed
@chalin chalin force-pushed the chalin-im-exporters-2024-01-31 branch 2 times, most recently from 64e4c51 to 0361626 Compare February 6, 2024 16:27
@chalin chalin mentioned this pull request Feb 6, 2024
Closed
@svrnm
Copy link
Member

svrnm commented Feb 7, 2024

@chalin , apologies merging the PR to update the short codes on the exporter pages created that conflict.

@chalin chalin force-pushed the chalin-im-exporters-2024-01-31 branch from 0361626 to e65dcba Compare February 7, 2024 10:42
@chalin chalin force-pushed the chalin-im-exporters-2024-01-31 branch from e65dcba to 7b0df3c Compare February 7, 2024 10:46
@chalin
Copy link
Contributor Author

chalin commented Feb 7, 2024

@svrnm - no worries. I've rebased, resolved conflicts, and slightly reworked the initial part of the exporters intro. PTAL

@chalin chalin force-pushed the chalin-im-exporters-2024-01-31 branch from 7b0df3c to b50b1d6 Compare February 7, 2024 10:48
@svrnm svrnm merged commit bcd9bcd into open-telemetry:main Feb 7, 2024
14 checks passed
@chalin chalin deleted the chalin-im-exporters-2024-01-31 branch February 7, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp left review comments

@MrAlias MrAlias MrAlias approved these changes

@cijothomas cijothomas cijothomas approved these changes

@theletterf theletterf theletterf approved these changes

@svrnm svrnm svrnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update exporters intro with advantages of OTLP
6 participants
@chalin @svrnm @theletterf @cijothomas @MrAlias @cartermp