Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github.com/dnwe/otelsarama to registry #3858

Merged
merged 12 commits into from
Jan 26, 2024
Merged

Add github.com/dnwe/otelsarama to registry #3858

merged 12 commits into from
Jan 26, 2024

Conversation

pellared
Copy link
Member

@pellared pellared requested a review from a team January 25, 2024 10:40
@pellared pellared changed the title Create instrumentation-go-ibm-sarama.yml Add github.com/dnwe/otelsarama to registry Jan 25, 2024
@pellared pellared mentioned this pull request Jan 25, 2024
Closed
@pellared
Copy link
Member Author

@open-telemetry/go-approvers PTAL

@svrnm
Copy link
Member

svrnm commented Jan 25, 2024

is this a replacement for https://opentelemetry.io/ecosystem/registry/?s=sarama ? if so please replace the existing file

svrnm
svrnm requested changes Jan 25, 2024
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, a few suggestions

data/registry/instrumentation-go-ibm-sarama.yml Show resolved Hide resolved
data/registry/instrumentation-go-ibm-sarama.yml Outdated Show resolved Hide resolved
data/registry/instrumentation-go-ibm-sarama.yml Show resolved Hide resolved
@pellared
Copy link
Member Author

is this a replacement for https://opentelemetry.io/ecosystem/registry/?s=sarama ? if so please replace the existing file

Not really, because the existing one can be still used for the deprecated github.com/Shopify/sarama. It is still used: https://pkg.go.dev/github.com/Shopify/sarama?tab=imports. I think we can have both in the registry.

@pellared pellared marked this pull request as draft January 25, 2024 12:21
@pellared pellared marked this pull request as ready for review January 25, 2024 12:26
@pellared pellared requested a review from svrnm January 25, 2024 12:27
@svrnm
Copy link
Member

svrnm commented Jan 26, 2024

is this a replacement for opentelemetry.io/ecosystem/registry/?s=sarama ? if so please replace the existing file

Not really, because the existing one can be still used for the deprecated github.com/Shopify/sarama. It is still used: pkg.go.dev/github.com/Shopify/sarama?tab=imports. I think we can have both in the registry.

Thanks for clarification. 👍

@cartermp cartermp merged commit d6bf36d into main Jan 26, 2024
16 checks passed
@cartermp cartermp deleted the pellared-patch-1 branch January 26, 2024 14:30
jaydeluca pushed a commit to jaydeluca/opentelemetry.io that referenced this pull request Jan 31, 2024
@pellared @jaydeluca
Add github.com/dnwe/otelsarama to registry (open-telemetry#3858)
cacdde4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@theletterf theletterf theletterf approved these changes

@svrnm svrnm svrnm approved these changes

@dmathieu dmathieu dmathieu approved these changes

Assignees
No one assigned
Labels
registry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pellared @svrnm @dmathieu @theletterf @MrAlias @cartermp