Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emphasize that there is no user-facing Otel Logs API #3856

Merged
merged 7 commits into from
Feb 14, 2024

Conversation

tigrannajaryan
Copy link
Member

No description provided.

@tigrannajaryan tigrannajaryan requested review from a team and jack-berg January 24, 2024 18:52
@svrnm
Copy link
Member

svrnm commented Jan 24, 2024

/fix:format

Copy link
Contributor

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we should copy that across languages, and also have it at https://opentelemetry.io/docs/concepts/signals/logs/

@svrnm svrnm added the sig:java label Jan 24, 2024
@svrnm
Copy link
Member

svrnm commented Feb 14, 2024

/fix:all

Copy link
Contributor

Copy link
Contributor

fix:all run failed, please check https://github.com/open-telemetry/opentelemetry.io/actions/runs/7900243344 for details

@svrnm
Copy link
Member

svrnm commented Feb 14, 2024

/fix:all

Copy link
Contributor

@svrnm
Copy link
Member

svrnm commented Feb 14, 2024

@tigrannajaryan please take a look at my copy edits, if they are OK with you. If so this is ready to be merged.

@tigrannajaryan
Copy link
Member Author

@tigrannajaryan please take a look at my copy edits, if they are OK with you. If so this is ready to be merged.

Looks good to me, thanks. Let's merge and we can improve further in a future PR.

@svrnm svrnm merged commit 3f52ad5 into main Feb 14, 2024
7 checks passed
@svrnm svrnm deleted the tigrannajaryan-patch-1 branch February 14, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants