Update metrics docs for JS #3853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svrnm <[email protected]>
Signed-off-by: svrnm <[email protected]>
theletterf
reviewed
Jan 24, 2024
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
cartermp
reviewed
Jan 27, 2024
chalin
reviewed
Jan 30, 2024
Co-authored-by: Patrice Chalin <[email protected]>
svrnm
commented
Feb 1, 2024
There was a problem hiding this comment.
@theletterf @chalin @cartermp just to add some context: the changes to this file are coming from some text I moved out from the JS docs to the general docs, I may not have all the knowledge about all the text if & how it makes sense, so if you have any suggestions to make that text better, provide me with inline suggestions:-)
svrnm
commented
Feb 1, 2024
Signed-off-by: svrnm <[email protected]>
Signed-off-by: svrnm <[email protected]>
|
@open-telemetry/docs-approvers , @open-telemetry/javascript-approvers please take another look. I removed a lot of the conceptual content from the "instrumentation" page since this belongs to the concepts page (and there I point to the guideline in the specs) |
chalin
approved these changes
Feb 2, 2024
cartermp
approved these changes
Feb 2, 2024
|
@open-telemetry/javascript-approvers PTAL! |
pichlermarc
approved these changes
Feb 15, 2024
thanks for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3229, this updates the first few sections for the instrumentation guidelines for JavaScript.
Preview: