-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edits to follow up contribution guidelines work #3846
Conversation
@svrnm @chalin Did the mirrored documentation guidelines change / were removed? I don't think we've them in prod: 7c1dcce Can't trace when/where they were removed. I take they no longer apply, as we use a more generic language in our new contribution guide. As they were still linked from contribution-guidelines I was wondering. |
Also, do we want to promote the newly created https://github.com/open-telemetry/opentelemetry.io/discussions board? I'd wait a bit before doing so, perhaps... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but I'd like to also get @chalin's approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggested tweak, otherwise LGTM overall :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! We need to add an alias for the page that was removed.
I'm ok with waiting a bit too. |
@chalin Changes applied, thanks! The alias is already here I think? https://github.com/open-telemetry/opentelemetry.io/pull/3846/files#diff-a3d923889a7028820da3c39a743bd702eb33e7333b64009b1384d444c7a1561aL4 |
👍
Yes! 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
e83dd07
to
308dbe3
Compare
Co-authored-by: Patrice Chalin <[email protected]>
308dbe3
to
986d476
Compare
This PR consolidates contribution docs further and erases the hidden
contribution-guidelines
doc, which was redundant.Preview: https://deploy-preview-3846--opentelemetry.netlify.app/docs/contributing/
Redirect test: https://deploy-preview-3846--opentelemetry.netlify.app/docs/contribution-guidelines