Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fix to python agent-config option #3743

Merged
merged 3 commits into from
Jan 14, 2024
Merged

Small fix to python agent-config option #3743

merged 3 commits into from
Jan 14, 2024

Conversation

boylea
Copy link
Contributor

@boylea boylea commented Jan 9, 2024

Found the correct string in the code here

Currently the user will get:

RuntimeError: Unsupported OTLP protocol 'http' is configured

@boylea boylea requested review from a team January 9, 2024 00:47
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 9, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@svrnm
Copy link
Member

svrnm commented Jan 9, 2024

@open-telemetry/python-approvers PTAL!

@cartermp cartermp added the sig-approval-missing Co-owning SIG didn't provide an approval label Jan 9, 2024
@cartermp cartermp removed the sig-approval-missing Co-owning SIG didn't provide an approval label Jan 14, 2024
@cartermp cartermp merged commit be4b7bc into open-telemetry:main Jan 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@theletterf theletterf theletterf approved these changes

@svrnm svrnm svrnm approved these changes

Assignees
No one assigned
Labels
sig:python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@boylea @svrnm @theletterf @srikanthccv @cartermp