Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in automatic.md #3719

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Fix typo in automatic.md #3719

merged 3 commits into from
Jan 5, 2024

Conversation

Jeldo
Copy link
Contributor

@Jeldo Jeldo commented Jan 3, 2024

Correct the endpoint value that differs from the description(http://otel-collector.opentelemetry.svc.cluster.local:4317) below.

@Jeldo Jeldo requested review from a team January 3, 2024 15:52
Copy link

linux-foundation-easycla bot commented Jan 3, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Jeldo / name: Taeyoung Kwak (379bb6d, 7e095b8)
  • ✅ login: svrnm / name: Severin Neumann (48b3d70)

@jaronoff97
Copy link
Contributor

It looks like the rest of the docs reference demo-collector, should we use that here instead?

use the same names in exporter endpoint
@Jeldo
Copy link
Contributor Author

Jeldo commented Jan 4, 2024

It looks like the rest of the docs reference demo-collector, should we use that here instead?

@jaronoff97 It would be helpful to understand if we use the same names throughout the document.

@svrnm svrnm merged commit d3fbb25 into open-telemetry:main Jan 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants