Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP: add more-examples link #3712

Merged
merged 4 commits into from
Jan 11, 2024
Merged

PHP: add more-examples link #3712

merged 4 commits into from
Jan 11, 2024

Conversation

runtu666
Copy link
Contributor

@runtu666 runtu666 commented Dec 26, 2023

@theletterf
Copy link
Member

Thanks! Made a suggestion.

@svrnm
Copy link
Member

svrnm commented Jan 8, 2024

thanks @runtu666 , please fix the linter issues.

Run npx gulp lint-md and npm run fix:format for that

@chalin chalin changed the title add more examples link PHP: add more-examples link Jan 8, 2024
@runtu666
Copy link
Contributor Author

thanks @runtu666 , please fix the linter issues.

Run npx gulp lint-md and npm run fix:format for that

done @svrnm

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@svrnm
Copy link
Member

svrnm commented Jan 11, 2024

@theletterf please re-review if your changes have been applied and you're satisfied now

@svrnm svrnm added the sig:php label Jan 11, 2024
@svrnm svrnm merged commit 07f7364 into open-telemetry:main Jan 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants