Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HyperDX to vendors.yaml #3696

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Add HyperDX to vendors.yaml #3696

merged 3 commits into from
Dec 19, 2023

Conversation

MikeShi42
Copy link
Contributor

Hello! We'd love to add HyperDX to the OpenTelemetry vendors list.

OTLP Docs: https://www.hyperdx.io/docs/install/opentelemetry
Distribution: We have a few SDK distributions such as JS or Python and even a Deno logger.
OSS: Our project is MIT licensed and available here: https://github.com/hyperdxio/hyperdx/blob/main/LICENSE
Contact: [email protected] or @MikeShi42 ([email protected] directly as well)

@MikeShi42 MikeShi42 requested a review from a team December 18, 2023 07:01
Copy link

linux-foundation-easycla bot commented Dec 18, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Mike!

@svrnm
Copy link
Member

svrnm commented Dec 18, 2023

@MikeShi42 I can not edit your PR and fix the refcache for you, please run npm run test-and-fix locally and make sure that the PR is up-to-date with main such that we are able to merge that PR eventually.

As a general piece of advice do never provide PRs from a fork within a GitHub organization, because they are read-only by default, please use your personal. Also work from a branch different to main, take a look at our Contribution Guidelines for more details: https://github.com/open-telemetry/opentelemetry.io/blob/main/CONTRIBUTING.md#pr-guidelines

@MikeShi42
Copy link
Contributor Author

@svrnm apologies for that, will definitely do for next time. I can also re-open the PR under a personal fork as well if easier.

@svrnm svrnm merged commit b0f84bb into open-telemetry:main Dec 19, 2023
14 checks passed
@svrnm
Copy link
Member

svrnm commented Dec 19, 2023

@svrnm apologies for that, will definitely do for next time. I can also re-open the PR under a personal fork as well if easier.

No worries, this happens, you're lucky as I could just merge it, make sure to do this next time!

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants