Fix code license, add NOTICE #3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svrnm <[email protected]>
theletterf
approved these changes
Dec 14, 2023
the change of the LICENSE file: no, the NOTICE file: maybe? |
|
I removed the NOTICE for now, because it may require more discussion |
cartermp
approved these changes
Dec 15, 2023
|
Oh my, thanks for noticing that copy-paste error. There was back and forth some time ago in terms of which file(s) to use, I think that that's how it slipped 🤷🏼♂️ IMHO the LICENSE-CODE file needs further changes, the copyright notice is for the code in this repo, not the code in the documentation AFAIK. I'll open a separate issue to track this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LICENSE-CODE file has a copy&paste error, fixed by this. I checked with other projects and the meaning of the license and the
Copyright [yyyy] [name of copyright owner]should not be replaced by a project name.I also added a NOTICE file as suggested by the apache license, see section 4.4 for details. Although our repo does not have a lot of content, I think it still helps to improve potential attributions.