Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add security incident response process #3675

Merged
merged 21 commits into from
Dec 16, 2023

Conversation

cartersocha
Copy link
Contributor

add security incident response process to website - copying over from sig-security

@cartersocha cartersocha requested a review from a team December 11, 2023 20:02
@cartersocha cartersocha requested review from a team December 11, 2023 20:05
@cartersocha
Copy link
Contributor Author

@svrnm I can remove the javascript files. That formatter did those changes automatically

chalin
chalin previously requested changes Dec 11, 2023
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svrnm I can remove the javascript files. That formatter did those changes automatically

@cartersocha - hmm, you must have a custom setup or custom config for Pettier, or maybe you're not using the right version? Maybe try running npm install to ensure that you're using the expected version of Prettier. But yes, all other changes should be removed -- otherwise FILE FORMAT will continue to fail.

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @cartersocha, I focused on the final that needs the review. Let me know if you need any help to get the unintended changes fixed.

content/en/docs/security/security-response.md Outdated Show resolved Hide resolved
content/en/docs/security/security-response.md Outdated Show resolved Hide resolved
content/en/docs/security/security-response.md Outdated Show resolved Hide resolved
content/en/docs/security/security-response.md Outdated Show resolved Hide resolved
@cartersocha cartersocha requested a review from svrnm December 13, 2023 23:36
@cartersocha cartersocha requested a review from chalin December 13, 2023 23:37
@cartersocha
Copy link
Contributor Author

Fix everything. Thanks for the feedback and suggestions @svrnm @chalin. Should be ready to go

@svrnm
Copy link
Member

svrnm commented Dec 14, 2023

Fix everything. Thanks for the feedback and suggestions @svrnm @chalin. Should be ready to go

Thanks!

Can a second person from @open-telemetry/sig-security-maintainers approve the PR as well? Then we can merge it.

Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion to make it explicit which team to ping.

content/en/docs/security/security-response.md Show resolved Hide resolved
content/en/docs/security/security-response.md Show resolved Hide resolved
content/en/docs/security/security-response.md Outdated Show resolved Hide resolved
@cartermp
Copy link
Contributor

@cartersocha this looks good overall. If you can address the bits from @jpkrohling then I think we can merge this.

@cartersocha
Copy link
Contributor Author

done @cartermp

@cartermp cartermp merged commit 2cafab0 into open-telemetry:main Dec 16, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants