Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin werkzeug version to fix python getting started issue #3655

Merged

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Dec 6, 2023

fixes #3610

Note that this is a hot fix, we should do some additional improvements to the python getting started in the future to avoid those kinds of issues from happening (i.e. pin the versions of all dependencies)

@svrnm svrnm requested review from a team December 6, 2023 18:15
@ekquasar
Copy link
Contributor

ekquasar commented Dec 6, 2023

Thank you 🙇‍♂️

I cannot review (I don't think) but I can validate that pinning werkzeug<3 fixes the issue.
When I install I get 2.3.8 not 2.3.7, maybe pin to <3 to indicate that the major version increment in werkzeug introduced the breaking change.

@svrnm
Copy link
Member Author

svrnm commented Dec 6, 2023

I cannot review (I don't think) but I can validate that pinning werkzeug<3 fixes the issue.

You can always review PRs on github, and they are helpful to drive the PR, but your review will not satisfy the review requirements.

When I install I get 2.3.8 not 2.3.7, maybe pin to <3 to indicate that the major version increment in werkzeug introduced the breaking change.

I updated it to <3 thanks

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@cartermp cartermp merged commit d8b6a97 into open-telemetry:main Dec 7, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python "getting started" demo does not produce output as shown on instructions
4 participants