Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update use of metadata in glossary.md #3646

Merged
merged 20 commits into from
Dec 16, 2023
Merged

Update use of metadata in glossary.md #3646

merged 20 commits into from
Dec 16, 2023

Conversation

flands
Copy link
Contributor

@flands flands commented Dec 5, 2023

Metadata and its definition are used inconsistently in the glossary. Make it consistent and clarify its use.

Metadata and its definition are used inconsistently in the glossary. Make it consistent and clarify its use.
@flands flands requested a review from a team December 5, 2023 01:12
content/en/docs/concepts/glossary.md Outdated Show resolved Hide resolved
content/en/docs/concepts/glossary.md Outdated Show resolved Hide resolved
content/en/docs/concepts/glossary.md Outdated Show resolved Hide resolved
content/en/docs/concepts/glossary.md Outdated Show resolved Hide resolved
Copy link
Member

@mhausenblas mhausenblas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and LGTM, essentially the same points that @theletterf already highlighted from my side.

@theletterf
Copy link
Member

Thanks!

@cartermp cartermp merged commit 8fea91c into main Dec 16, 2023
16 checks passed
@cartermp cartermp deleted the flands-glossary-patch-1 branch December 16, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants