Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Remove /v1/traces from OTEL_EXPORTER_OTLP_ENDPOINT #3627

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

mizukmb
Copy link
Contributor

@mizukmb mizukmb commented Dec 1, 2023

OTEL_EXPORTER_OTLP_ENDPOINT="http://localhost:4318/v1/traces" did not work as expected.

E, [2023-12-01T20:15:29.518443 #15315] ERROR -- : OpenTelemetry error: OTLP exporter received http.code=404 for uri: '/v1/v1/traces'
E, [2023-12-01T20:15:29.518806 #15315] ERROR -- : OpenTelemetry error: Unable to export 1 spans

It works correctly when removing "/v1/traces" from the endpoint.

`OTEL_EXPORTER_OTLP_ENDPOINT="http://localhost:4318/v1/traces"` did not work as expected.

```
E, [2023-12-01T20:15:29.518443 #15315] ERROR -- : OpenTelemetry error: OTLP exporter received http.code=404 for uri: '/v1/v1/traces'
E, [2023-12-01T20:15:29.518806 #15315] ERROR -- : OpenTelemetry error: Unable to export 1 spans
```

It works correctly when removing "/v1/traces" from the endpoint.
@mizukmb mizukmb requested review from a team December 1, 2023 11:37
Copy link

linux-foundation-easycla bot commented Dec 1, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mizukmb / name: Yuto MIZUSHIRI (951fd96)
  • ✅ login: theletterf / name: Fabrizio Ferri-Benedetti (103a670)
  • ✅ login: svrnm / name: Severin Neumann (8e339a3)

@theletterf
Copy link
Member

theletterf commented Dec 1, 2023

@open-telemetry/collector-approvers @open-telemetry/ruby-contrib-maintainers This seems correct according to the specs? https://github.com/open-telemetry/opentelemetry-specification/blob/v1.27.0/specification/protocol/exporter.md

If you can confirm, I'll approve the PR.

@cartermp
Copy link
Contributor

cartermp commented Dec 1, 2023

Yes, this change is correct (or at least should be). When specifying the env var without the signal in the name, then the signal part of the URL is supposed to be added at the end for you.

@svrnm svrnm added the sig:ruby label Dec 1, 2023
@svrnm svrnm merged commit e7bb081 into open-telemetry:main Dec 1, 2023
14 checks passed
@mizukmb mizukmb deleted the fix-docs-ruby-exporters branch December 1, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants