Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update community members in README #3598

Merged
merged 6 commits into from
Nov 29, 2023

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Nov 24, 2023

I would like to update the approvers & maintainers for our repository and at the same team structure the README similar to what other SIGs have on their repos (see https://github.com/open-telemetry/community/blob/main/community-members.md)

This should then also be reflected in changing @open-telemetry/docs-approvers , @open-telemetry/blog-approvers and @open-telemetry/docs-maintainers:

  • Drop @open-telemetry/blog-approvers and replace it with docs-maintainers (i.e. a maintainer needs to approve a blog post, an approver is not enough)
  • Update @open-telemetry/docs-maintainers to reflect the current state: keep @austinlparker, @chalin, @cartermp and me. Remove @mtwo, @flands & @jparsana except they want to stay on that group explicitly.
  • Update @open-telemetry/docs-approvers, I'd like to nominate @theletterf and @mhausenblas to be included, since both have contributed consistently over the last few months and both are willing to continue to help reviewing future PRs. Remove @paulsbruce except they want to stay on that group explicitly.

If this PR gets merged, I would raise a follow-up PR to reflect that change in the community repo as well:

open-telemetry/community@main...svrnm:community:update-docs-section-in-members

@svrnm svrnm requested review from a team November 24, 2023 09:15
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! And I endorse @theletterf and @mhausenblas to be approvers

@cartermp
Copy link
Contributor

Hmm. I think @theletterf and @mhausenblas need to create the issue in the community repo to get added to the appropriate teams?

@cartermp
Copy link
Contributor

Otherwise, this is good to merge by me, I'll comment wherever to get the ball rolling

@svrnm
Copy link
Member Author

svrnm commented Nov 27, 2023

Hmm. I think @theletterf and @mhausenblas need to create the issue in the community repo to get added to the appropriate teams?

Until we have the automation for that in place, I think @austinlparker should have all the power to accomplish this

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 ✨

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this PR should probably also include .github/CODEOWNERS changes: e.g., removing @open-telemetry/blog-approvers.

@svrnm
Copy link
Member Author

svrnm commented Nov 27, 2023

Hmm, this PR should probably also include .github/CODEOWNERS changes: e.g., removing @open-telemetry/blog-approvers.

fixed.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Piotr Kiełkowicz <[email protected]>
@theletterf
Copy link
Member

Anything needed from my end?

@austinlparker
Copy link
Member

@mhausenblas and @theletterf have been added as maintainers

@austinlparker
Copy link
Member

@mhausenblas and @theletterf have been added as maintainers

Correction - they are approvers, not maintainers. Fixed!

@cartermp cartermp merged commit e77c6de into open-telemetry:main Nov 29, 2023
14 checks passed
@svrnm
Copy link
Member Author

svrnm commented Nov 29, 2023

Anything needed from my end?

Nope.

🎉 welcome @mhausenblas & @theletterf, happy to have you onboard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants