-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update community members in README #3598
Conversation
Signed-off-by: svrnm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! And I endorse @theletterf and @mhausenblas to be approvers
Hmm. I think @theletterf and @mhausenblas need to create the issue in the community repo to get added to the appropriate teams? |
Otherwise, this is good to merge by me, I'll comment wherever to get the ball rolling |
Until we have the automation for that in place, I think @austinlparker should have all the power to accomplish this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this PR should probably also include .github/CODEOWNERS
changes: e.g., removing @open-telemetry/blog-approvers.
Signed-off-by: svrnm <[email protected]>
fixed. |
Co-authored-by: Piotr Kiełkowicz <[email protected]>
Anything needed from my end? |
@mhausenblas and @theletterf have been added as maintainers |
Correction - they are approvers, not maintainers. Fixed! |
Nope. 🎉 welcome @mhausenblas & @theletterf, happy to have you onboard! |
I would like to update the approvers & maintainers for our repository and at the same team structure the README similar to what other SIGs have on their repos (see https://github.com/open-telemetry/community/blob/main/community-members.md)
This should then also be reflected in changing @open-telemetry/docs-approvers , @open-telemetry/blog-approvers and @open-telemetry/docs-maintainers:
If this PR gets merged, I would raise a follow-up PR to reflect that change in the community repo as well:
open-telemetry/community@main...svrnm:community:update-docs-section-in-members