Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pr actions, part 2 #3593

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Fix pr actions, part 2 #3593

merged 4 commits into from
Nov 28, 2023

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Nov 23, 2023 •
edited
Loading

🙄 I missed a few things with #3590:

  • the checkout of the repo needs to happen first
  • to comment on PRs permissions are required
  • to use gh the step needs github.token
  • the variables set by gh pr checkout are different if the repo is upstream or a fork, I compared them and hopefully use the right ones now

Examples: https://github.com/svrnm/opentelemetry.io-pr-test/pulls

@svrnm svrnm requested a review from a team November 23, 2023 18:42
@svrnm svrnm mentioned this pull request Nov 23, 2023
Closed
@svrnm svrnm marked this pull request as draft November 23, 2023 19:02
@svrnm svrnm added the CI/infra CI & infrastructure label Nov 23, 2023
@svrnm svrnm marked this pull request as ready for review November 23, 2023 20:18
chalin
chalin approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! RSLGTM

@cartermp cartermp merged commit 0f4e097 into main Nov 28, 2023
16 checks passed
@cartermp cartermp deleted the pr-actions-followup branch November 28, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@chalin chalin chalin approved these changes

@theletterf theletterf theletterf approved these changes

Assignees
No one assigned
Labels
CI/infra CI & infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@svrnm @theletterf @chalin @cartermp