Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inits logs collection blog post #3557

Merged
merged 46 commits into from
Nov 21, 2023
Merged

inits logs collection blog post #3557

merged 46 commits into from
Nov 21, 2023

Conversation

mhausenblas
Copy link
Member

@mhausenblas mhausenblas commented Nov 17, 2023 •
edited
Loading

Preview

The site currently doesn't build due to some Hugo/Docsy fun I am not able to fix myself (I suspect due to the non-standard sub-directory structure in the blog post itself I have, with things like yoda/ that contains no Markdown files.

Fixed by running npm install, kudos to @svrnm for the help!

@mhausenblas mhausenblas requested review from a team November 17, 2023 09:53
chalin
chalin previously requested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick comment before I take a deeper dive.

.gitignore Outdated Show resolved Hide resolved
@svrnm svrnm added the blog label Nov 20, 2023
svrnm
svrnm requested changes Nov 21, 2023
View reviewed changes
content/en/blog/2023/logs-collection/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/logs-collection/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/logs-collection/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/logs-collection/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/logs-collection/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/logs-collection/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/logs-collection/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/logs-collection/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/logs-collection/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/logs-collection/index.md Outdated Show resolved Hide resolved
mhausenblas and others added 10 commits November 21, 2023 11:49
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
ae49cab 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
e9e1285 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
8cf034f 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
e3ea12b 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
ce4b660 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
e1bc411 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
80ef180 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
4e3ed12 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
8c5bf43 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
900a468 
Co-authored-by: Severin Neumann <[email protected]>
mhausenblas and others added 20 commits November 21, 2023 11:52
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
d64562c 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
f9373c9 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
24817fa 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
07b0ec1 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
50d6767 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
6960e8b 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
81be4fe 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
0dea320 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
018d799 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
6259e4c 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
a10db52 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas @svrnm
Update content/en/blog/2023/logs-collection/index.md
845524d 
Co-authored-by: Severin Neumann <[email protected]>
@mhausenblas
updates code repo
9f4ab32
@mhausenblas
removes code from blog
468a9d5
@mhausenblas
fixes repo links
8698ffc
@mhausenblas
fixes formatting
54d4cfe
@mhausenblas
Merge branch 'main' into mh9-logs-collection
67b22fe
@mhausenblas
fixes formatting
d182a94
@mhausenblas
fixes formatting
42f5872
@mhausenblas
upgrades to mermaid graphs
da0835e
@mhausenblas
Copy link
Member Author

Thanks for your review @svrnm and I addressed all of your comments including moving the code out and upgrading to Mermaid graphs.

cartermp
cartermp approved these changes Nov 21, 2023
View reviewed changes
content/en/blog/2023/logs-collection/index.md Outdated Show resolved Hide resolved
@mhausenblas @cartermp
Update index.md
4fd668e 
Co-authored-by: Phillip Carter <[email protected]>
@svrnm svrnm dismissed chalin’s stale review November 21, 2023 14:52

all changes have been applied

@svrnm svrnm merged commit 6b8010b into open-telemetry:main Nov 21, 2023
14 checks passed
@mhausenblas mhausenblas deleted the mh9-logs-collection branch November 21, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@svrnm svrnm svrnm approved these changes

@chalin chalin chalin left review comments

Assignees
No one assigned
Labels
blog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mhausenblas @svrnm @chalin @cartermp