-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tutorials of both "Building a custom collector" and "Building a Trace Receiver" #3524
Update tutorials of both "Building a custom collector" and "Building a Trace Receiver" #3524
Conversation
Hey @brightzheng100, thanks for taking the effort to improve those 2 documents, that's highly appreciated. I will try to provide you with a feedback soon. @open-telemetry/collector-approvers please take a look as well! |
719f70a
to
752b96a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good to me. Please add telemetrygen
to the cSpell:ignore list in line 5
@open-telemetry/collector-approvers PTAL!
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
@open-telemetry/collector-approvers please take a look! |
I recently tried out the tracer receiver tutorial by using the updates from this PR and it worked just fine 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane, but I didn't try this. Given that @svrnm did, I'm approving this, although I'd love to see the couple of changes I suggested.
Now, create another folder called `tailtracer` so we can have a place to host | ||
all of our receiver code. | ||
You may use the | ||
[telemetrygen](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/cmd/telemetrygen) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this URL be parameterized as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good idea but this URL might be stable enough to last for a while I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this conversation be resolved?
Co-authored-by: Juraci Paixão Kröhling <[email protected]>
@brightzheng100 can you fix the merge conflicts? |
…' into update-building-a-trace-receiver
There are quite a lot of changes after my PR as it's been a while. But I've tried to merge and test so you may have a final review and let me know if further changes are needed. |
@brightzheng100 I think if you run |
Done! I was seeing exceptions when running But actually if I were to look into those exceptions, I should know how to fix those issues one by one based on the exception messages. Not sure whether this is the right way like what I did (by looking into the exceptions) for contributors to review before
|
Huh, interesting. Maybe it's a bug in the linting tool we use. |
Re issue: #3488
This PR has two tutorials / files updated.
In "Building a custom collector":
In "Building a Trace Receiver":
v
in the path. For example:/blob/v{{% param collectorVersion %}}/pdata/
;