Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework CONTRIBUTING.md #3520

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Rework CONTRIBUTING.md #3520

merged 6 commits into from
Nov 9, 2023

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Nov 8, 2023

I started to write down some additional details to our contributors guidelines, I also used the opportunity to add some generic pieces.

@svrnm svrnm requested a review from a team November 8, 2023 19:11
chalin
chalin approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these additions! See inline comments

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
.vscode/cspell.json Show resolved Hide resolved
chalin
chalin approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from one comment.

.textlintrc.yml Outdated Show resolved Hide resolved
@svrnm @chalin
Update .textlintrc.yml
4814988 
Co-authored-by: Patrice Chalin <[email protected]>
svrnm
svrnm commented Nov 9, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
cartermp
cartermp approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the preamble's a little wordy, but it's still good.

@cartermp cartermp merged commit 9ffdd3f into open-telemetry:main Nov 9, 2023
14 checks passed
@svrnm svrnm deleted the rework-contributing-md branch November 9, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svrnm @chalin @cartermp