Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the python exporters page #3515

Merged
merged 9 commits into from
Dec 19, 2023

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Nov 8, 2023

Based on #3355 I updated the python exporters documentation to have a similar structure.


Preview: https://deploy-preview-3515--opentelemetry.netlify.app/docs/instrumentation/python/exporters/

@svrnm svrnm requested review from a team November 8, 2023 15:24
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more copyedits. Otherwise LGTM overall.

content/en/docs/instrumentation/python/exporters.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/python/exporters.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/python/exporters.md Outdated Show resolved Hide resolved
@cartermp
Copy link
Contributor

@open-telemetry/python-approvers can you take a look?

@svrnm svrnm mentioned this pull request Nov 17, 2023
11 tasks
@cartermp
Copy link
Contributor

@open-telemetry/python-approvers ping!

@svrnm
Copy link
Member Author

svrnm commented Nov 23, 2023

/fix:format

@svrnm
Copy link
Member Author

svrnm commented Dec 7, 2023

@open-telemetry/python-approvers PTAL!

@svrnm svrnm added the sig-approval-missing Co-owning SIG didn't provide an approval label Dec 15, 2023
@svrnm
Copy link
Member Author

svrnm commented Dec 15, 2023

@open-telemetry/python-approvers PTAL!

@cartermp
Copy link
Contributor

@cartermp cartermp merged commit 41cccbd into open-telemetry:main Dec 19, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig:python sig-approval-missing Co-owning SIG didn't provide an approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants