Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong Signals interface path import #3489

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Fix wrong Signals interface path import #3489

merged 1 commit into from
Nov 5, 2023

Conversation

gaelreyrol
Copy link
Contributor

The gRPC exporter example contains an import to outdated path for the Signals interface.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 4, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: gaelreyrol / name: Gaël Reyrol (064ff65)

cartermp
cartermp approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-telemetry/php-approvers can you take a look?

@gaelreyrol gaelreyrol marked this pull request as ready for review November 4, 2023 21:39
@gaelreyrol gaelreyrol requested review from a team November 4, 2023 21:39
@chalin chalin force-pushed the fix-signals-class-path branch from 8bfbf3b to 064ff65 Compare November 4, 2023 22:39
@cartermp cartermp merged commit 96af07d into open-telemetry:main Nov 5, 2023
12 checks passed
@gaelreyrol gaelreyrol deleted the fix-signals-class-path branch November 5, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@brettmc brettmc brettmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaelreyrol @brettmc @cartermp