Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add performance testing blog post #3470

Merged
merged 17 commits into from
Nov 22, 2023
Merged

Add performance testing blog post #3470

merged 17 commits into from
Nov 22, 2023

Conversation

martinkuba
Copy link
Contributor

@martinkuba martinkuba commented Nov 2, 2023 •
edited by chalin
Loading

@martinkuba martinkuba force-pushed the performance-testing-blog branch 5 times, most recently from a88d5d6 to 395660b Compare November 2, 2023 00:26
chalin
chalin reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

See inline for copyedits.

content/en/blog/2023/perf-testing/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/perf-testing/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/perf-testing/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/perf-testing/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/perf-testing/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/perf-testing/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/perf-testing/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/perf-testing/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/perf-testing/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/perf-testing/index.md Outdated Show resolved Hide resolved
@martinkuba
Copy link
Contributor Author

martinkuba commented Nov 2, 2023 •
edited
Loading

@chalin Thank you for the review! I have made the changes based on your suggestions.

I am not sure how to fix the two failing workflows. The TEXT linter is failing because it wants to capitalize java in SpanBenchmark.java. And for the REFCACHE check, I tried running npm run test-and-fix, but it's not updating anything.

@martinkuba martinkuba marked this pull request as ready for review November 2, 2023 23:02
@martinkuba martinkuba requested review from a team November 2, 2023 23:02
cartersocha
cartersocha approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@cartersocha cartersocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cartersocha
Copy link
Contributor

@svrnm / @cartermp with all the kubecon blogs I think we might want to sit on this one until post kube con for release. Just a thought

@chalin chalin force-pushed the performance-testing-blog branch from ae97b0c to f54e053 Compare November 4, 2023 15:03
@chalin chalin mentioned this pull request Nov 4, 2023
Merged
@chalin
Copy link
Contributor

chalin commented Nov 4, 2023

The TEXT linter is failing because it wants to capitalize java in SpanBenchmark.java

I've submitted a fix (#3492). We'll need to wait for that to land so that you can rebase.

REFCACHE check, I tried running npm run test-and-fix, but it's not updating anything

Hmm, test-and-fix works for me. I've submitted the updated refcache file.

martinkuba and others added 13 commits November 4, 2023 11:53
@martinkuba @chalin
perf testing blog post
7552841
@martinkuba @chalin
updated title
4acc417 
Co-authored-by: Patrice Chalin <[email protected]>
@martinkuba @chalin
updated linkTitle
0f6edaf 
Co-authored-by: Patrice Chalin <[email protected]>
@martinkuba @chalin
updated example benchmark tests
5760b68 
Co-authored-by: Patrice Chalin <[email protected]>
@martinkuba @chalin
punctuation
eb685a0 
Co-authored-by: Patrice Chalin <[email protected]>
@martinkuba @chalin
removed e.g.
a35cb9e 
Co-authored-by: Patrice Chalin <[email protected]>
@martinkuba @chalin
rewording
27c7e13 
Co-authored-by: Patrice Chalin <[email protected]>
@martinkuba @chalin
punctuation
1f7922b 
Co-authored-by: Patrice Chalin <[email protected]>
@martinkuba @chalin
updates to rendering images
fde06bc 
Co-authored-by: Patrice Chalin <[email protected]>
@martinkuba @chalin
formatting
18b34a9 
Co-authored-by: Patrice Chalin <[email protected]>
@martinkuba @chalin
fixed section header
5cabb77
@martinkuba @chalin
fix format
88b9152
@chalin
Update refcache.json
8de12af
@chalin chalin force-pushed the performance-testing-blog branch from 5e37ab7 to 8de12af Compare November 4, 2023 15:53
@cartermp
Copy link
Contributor

cartermp commented Nov 4, 2023

@cartersocha agreed, this can be post-kubecon. E_TOO_MANY_BLOG_POSTS

@chalin
Copy link
Contributor

chalin commented Nov 4, 2023

All checks are ✅

svrnm
svrnm approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, but I agree let's push this out post KubeCon

content/en/blog/2023/perf-testing/index.md Outdated Show resolved Hide resolved
@svrnm svrnm added the blog label Nov 13, 2023
@cartermp
Copy link
Contributor

Hrm. Did #3492 not fix the issue, or is there just some git branch fuckery going on causing the textlint check to fail again?

@svrnm
Copy link
Member

svrnm commented Nov 22, 2023

Hrm. Did #3492 not fix the issue, or is there just some git branch fuckery going on causing the textlint check to fail again?

Seems that the changes from that PR got not carried over when we switched from JSON to YAML

@svrnm svrnm mentioned this pull request Nov 22, 2023
Merged
@cartermp cartermp merged commit 384a9ed into open-telemetry:main Nov 22, 2023
12 checks passed
@cartermp
Copy link
Contributor

Will be published on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

@cartersocha cartersocha cartersocha approved these changes

@JaredTan95 JaredTan95 JaredTan95 approved these changes

@cartermp cartermp cartermp approved these changes

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
blog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@martinkuba @cartersocha @chalin @cartermp @svrnm @JaredTan95