Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Tyk API Gateway blog post #3431

Merged
merged 11 commits into from
Nov 7, 2023
Merged

Adds Tyk API Gateway blog post #3431

merged 11 commits into from
Nov 7, 2023

Conversation

SonjaChevre
Copy link

@SonjaChevre SonjaChevre commented Oct 24, 2023

Here is a blog post discussing Tyk's native integration of OpenTelemetry.
thanks in advance for helping publishing it!


Preview: https://deploy-preview-3431--opentelemetry.netlify.app/blog/2023/tyk-api-gateway/

@SonjaChevre SonjaChevre requested review from a team October 24, 2023 08:00
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SonjaChevre, I provided some feedback but overall it looks good to me.

@cartersocha (& @open-telemetry/blog-approvers): We should think about adding a small paragraph at the top of that blog post saying something like "otel community is super excited about integrations, this is a features blog post by Tyk, do you also integrate? let us know". WDYT?

content/en/blog/2023/tyk-api-gateway/index.md Show resolved Hide resolved
content/en/blog/2023/tyk-api-gateway/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/tyk-api-gateway/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/tyk-api-gateway/index.md Outdated Show resolved Hide resolved
@austinlparker
Copy link
Member

I think that's fine @svrnm, do you want to just add that into the PR directly?

@SonjaChevre SonjaChevre requested a review from svrnm October 24, 2023 08:22
@cartersocha
Copy link
Contributor

sgtm @svrnm

@svrnm
Copy link
Member

svrnm commented Oct 25, 2023

I think that's fine @svrnm, do you want to just add that into the PR directly?

Yes, I can come up with some words later today/tomorrow except someone is able to provide them earlier:D

Copy link
Contributor

@cartersocha cartersocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm in general besides the nit comments. @svrnm anything additional needed besides resolving the existing comment?

@cartersocha cartersocha requested a review from cartermp October 31, 2023 16:40
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few copyedits, including a link fix.

content/en/blog/2023/tyk-api-gateway/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/tyk-api-gateway/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/tyk-api-gateway/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/tyk-api-gateway/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/tyk-api-gateway/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/tyk-api-gateway/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/tyk-api-gateway/index.md Outdated Show resolved Hide resolved
chalin
chalin previously requested changes Nov 6, 2023
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the top-of-page alert by a badge.

content/en/blog/2023/tyk-api-gateway/index.md Outdated Show resolved Hide resolved
@svrnm
Copy link
Member

svrnm commented Nov 6, 2023

will publish this one tomorrow (Nov 7th)

@svrnm svrnm requested review from chalin and svrnm November 7, 2023 09:37
@svrnm svrnm dismissed chalin’s stale review November 7, 2023 09:37

Changes have been applied

@svrnm svrnm merged commit 974e9be into open-telemetry:main Nov 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants