Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs to python getting started #3360

Merged

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Oct 10, 2023

following the instructions of Logs Example, I was able to add logging capabilities to the python getting started


Preview: https://deploy-preview-3360--opentelemetry.netlify.app/docs/instrumentation/python/getting-started/

@svrnm svrnm requested review from a team October 10, 2023 08:48
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo conflicts

@cartermp
Copy link
Contributor

@open-telemetry/python-approvers can we get a look?

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from one copyedit, and the conflicts that will need to be resolved.

content/en/docs/instrumentation/python/getting-started.md Outdated Show resolved Hide resolved
@svrnm
Copy link
Member Author

svrnm commented Nov 7, 2023

@open-telemetry/python-approvers PTAL!

@cartermp
Copy link
Contributor

Since this has several approvals and this is relatively straightforward and stable code, I'll merge.

@cartermp cartermp merged commit 1066567 into open-telemetry:main Nov 22, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants