Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add blogpost on migrating away from the Jaeger exporter #3273

Conversation

codeboten
Copy link
Contributor

This is to help users that upgrade to v0.85.0 of the OTel Collector.

@codeboten codeboten requested review from a team September 14, 2023 15:47
svrnm
svrnm previously requested changes Sep 14, 2023
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy to have it as a blog post to announce and promote it better, but eventually this should be placed somewhere here: https://opentelemetry.io/docs/migration/#jaeger-client

@codeboten
Copy link
Contributor Author

I am happy to have it as a blog post to announce and promote it better, but eventually this should be placed somewhere here: https://opentelemetry.io/docs/migration/#jaeger-client

Right the documentation already covers how to use OTLP to send data to Jaeger since #3262, I'm happy to move this content wherever it makes the most sense in the future.

```yaml
exporters:
otlp/jaeger: # Jaeger supports OTLP directly. The default port for OTLP/gRPC is 4317
endpoint: https://jaeger.example.com:4317
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TLS is not enabled in Jaeger by default, it's worth calling out here.

@codeboten codeboten force-pushed the codeboten/blogpost-migrate-jaeger-exporter branch from ad199f6 to da63622 Compare September 18, 2023 21:38
@cartermp
Copy link
Contributor

@codeboten if you run npm run test-and-fix then this should go green.

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten force-pushed the codeboten/blogpost-migrate-jaeger-exporter branch from 3fa2784 to 4040ead Compare September 18, 2023 22:37
Signed-off-by: Alex Boten <[email protected]>
@codeboten
Copy link
Contributor Author

@cartermp what should i do with the refcache check?

@cartermp
Copy link
Contributor

Hmm, did npm run test-and-fix not work? That should be the fix.

@codeboten
Copy link
Contributor Author

codeboten commented Sep 19, 2023

so test-and-fix didn't show any changed files.... and running fix:format gives me a bunch of unrelated changes:

        modified:   assets/js/registrySearch.js
        modified:   content/en/blog/2022/instrument-apache-httpd-server/index.md
        modified:   content/en/docs/instrumentation/js/getting-started/browser.md
        modified:   content/en/docs/instrumentation/js/manual.md
        modified:   content/en/docs/instrumentation/js/propagation.md
        modified:   content/en/docs/instrumentation/js/serverless.md
        modified:   gulp-src/_md-rules/trim-code-block-and-unindent.js
        modified:   gulp-src/prune.js
        modified:   scripts/registry-scanner/index.mjs

Do i have to commit those?

@cartermp
Copy link
Contributor

@codeboten I'll just go ahead and merge this and fix stuff in main. I think we had some errant unformatted changes (which is weird since CI should have caught them)

@codeboten
Copy link
Contributor Author

Thanks @cartermp!

@cartermp cartermp merged commit 6503b54 into open-telemetry:main Sep 19, 2023
11 of 12 checks passed
@codeboten codeboten deleted the codeboten/blogpost-migrate-jaeger-exporter branch September 19, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants