Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New blog post on how to contribute to OTel #3238

Merged
merged 22 commits into from
Sep 14, 2023
Merged

New blog post on how to contribute to OTel #3238

merged 22 commits into from
Sep 14, 2023

Conversation

avillela
Copy link
Contributor

@avillela avillela commented Sep 8, 2023 •
edited
Loading

Blog post on how to contribute to OTel as discussed with @svrnm

Related: #3254

@avillela avillela requested review from a team September 8, 2023 15:07
svrnm
svrnm requested changes Sep 11, 2023
View reviewed changes
content/en/blog/2023/contributing-to-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/contributing-to-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/contributing-to-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/contributing-to-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/contributing-to-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/contributing-to-otel/index.md Show resolved Hide resolved
content/en/blog/2023/contributing-to-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/contributing-to-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/contributing-to-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/contributing-to-otel/turks-sunset.jpg Outdated Show resolved Hide resolved
@avillela avillela mentioned this pull request Sep 11, 2023
Closed
@avillela avillela requested a review from svrnm September 12, 2023 16:20
svrnm
svrnm requested changes Sep 13, 2023
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me overall, 2 more comments

content/en/blog/2023/contributing-to-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/contributing-to-otel/index.md Outdated Show resolved Hide resolved
svrnm
svrnm approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me now!

@open-telemetry/docs-approvers any more comments? PTAL before merge!:)

content/en/blog/2023/contributing-to-otel/index.md Outdated Show resolved Hide resolved
@cartermp cartermp merged commit 4d7c6ae into open-telemetry:main Sep 14, 2023
13 checks passed
@svrnm
Copy link
Member

svrnm commented Sep 14, 2023

@cartermp publication date is set to date: 2023-09-18 so we have to make sure that something gets merged on Monday to make the blog show up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@svrnm svrnm svrnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avillela @svrnm @cartermp