Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use Perl Core module JSON::PP #3188

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Aug 16, 2023

@chalin chalin requested a review from a team August 16, 2023 13:48
@chalin chalin mentioned this pull request Aug 16, 2023
12 tasks
@julianocosta89
Copy link
Member

Thanks @chalin 🤩

@chalin chalin force-pushed the chalin-im-json-pp-2023-08-16 branch from 9529d28 to ebf5c4a Compare August 16, 2023 14:16
@chalin
Copy link
Contributor Author

chalin commented Aug 16, 2023

@julianocosta89 - if this works for you, could you approve the PR? Thanks.

@julianocosta89
Copy link
Member

I'm on my mobile ATM, but I can take a look tomorrow if that's fine.

@chalin
Copy link
Contributor Author

chalin commented Aug 16, 2023

Thanks, no problem. @cartermp might get to reviewing it before then.

@chalin chalin force-pushed the chalin-im-json-pp-2023-08-16 branch from ebf5c4a to fd78d6d Compare August 16, 2023 22:30
@chalin chalin merged commit 20230e6 into open-telemetry:main Aug 16, 2023
@chalin chalin deleted the chalin-im-json-pp-2023-08-16 branch August 16, 2023 22:34
@julianocosta89
Copy link
Member

Added the error message here: #3187 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] fix:dict fails due to missing JSON package
3 participants