Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some docs to rust #3123

Merged
merged 11 commits into from
Aug 11, 2023
Merged

add some docs to rust #3123

merged 11 commits into from
Aug 11, 2023

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Aug 1, 2023

No a rust expert, but I used some of the existing examples to get this very basic getting started example together. Hope it makes sense ;-)

cc @open-telemetry/rust-approvers

@svrnm svrnm requested review from a team August 1, 2023 14:11
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more copyedits.

content/en/docs/instrumentation/rust/exporters.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/rust/exporters.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/rust/exporters.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/rust/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/rust/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/rust/getting-started.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM -- @open-telemetry/rust-approvers can you give this a look?

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chalin
Copy link
Contributor

chalin commented Aug 11, 2023

Thanks @svrnm et al.!

@chalin chalin merged commit b37511d into open-telemetry:main Aug 11, 2023
@hdost
Copy link
Contributor

hdost commented Aug 15, 2023

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants