Move Ruby adopters to data-driven list #3090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
force-pushed
the
move-ruby-adopters
branch
from
eb5482a to
22dfb1e
Compare
chalin
reviewed
Jul 27, 2023
chalin
force-pushed
the
move-ruby-adopters
branch
from
22dfb1e to
5a5cd1e
Compare
|
/fix:format -- was only missing an EOF newline 🤷🏼♂️ |
4 tasks
chalin
force-pushed
the
move-ruby-adopters
branch
from
dbe01c5 to
7b10750
Compare
|
@open-telemetry/ruby-approvers - any feedback? The end result, though things were refactored, is minor copyedits to the Ruby landing page. All checks are green. Good to merge? |
I think the biggest difference will be that for those adopters PR #3089 will also apply |
chalin
reviewed
Jul 28, 2023
| <!-- prettier-ignore --> | ||
| {{ $lang := .Get 0 -}} | ||
| {{ $Lang := $lang | humanize -}} | ||
| {{ $howMany := .Get 1 | default 10 -}} |
There was a problem hiding this comment.
Btw, @svrnm, I don't know if you noticed, but I put a cap on the number of adopters. There's a comment at the end that says "for the complete list ... see". This will avoid excessively long lists.
chalin
force-pushed
the
move-ruby-adopters
branch
from
e253783 to
874f0c5
Compare
svrnm
added a commit
to svrnm/opentelemetry.io
that referenced
this pull request
Aug 1, 2023
Co-authored-by: Patrice Chalin <[email protected]> Co-authored-by: opentelemetrybot <[email protected]> Co-authored-by: Phillip Carter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-Up to #3060
This moves the ruby-specific adopters list to the global adopters list.
This will create a conflict with #3089, I'll resolve it after this one is merged since the other one will probably take longer.
@chalin I need your help to get the new shortcode fixed in a way that prettier & textlint are not breaking.
Preview: https://deploy-preview-3090--opentelemetry.netlify.app/docs/instrumentation/ruby/