Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: make netlify-cli optional #3084

Merged
merged 2 commits into from
Jul 26, 2023
Merged

CI: make netlify-cli optional #3084

merged 2 commits into from
Jul 26, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jul 26, 2023

  • Contributes to CI improvements - 2023/07 #3083
  • Specifies netlify-cli as optional, because this package isn't used in CI, and it brings in a lot of baggage
  • Updates GH action scripts:
    • Deletes optionalDependencies from minimal package.json files
    • Adds --omit=optional to explicit npm install commands to (transitively) omit optional packages from all dependencies
  • Updates serve:netlify (via a pre script) to test for and otherwise install netlify-cli only when the script is invoked

@chalin chalin added the CI/infra CI & infrastructure label Jul 26, 2023
@chalin chalin requested a review from a team July 26, 2023 14:41
@chalin chalin force-pushed the chalin-im-make-netlify-cli-optional-2023-07-26 branch from 1259a56 to bc463e8 Compare July 26, 2023 14:42
@chalin chalin mentioned this pull request Jul 26, 2023
Closed
18 tasks
@cartermp cartermp merged commit b38b1e0 into open-telemetry:main Jul 26, 2023
@chalin chalin deleted the chalin-im-make-netlify-cli-optional-2023-07-26 branch July 26, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
CI/infra CI & infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @cartermp